linux-kernel - Re: [PATCH 01/10] staging: slicoss: slic.h: add a macro IOMEM_GET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160916125727.GC29701@kroah.com>
Date:   Fri, 16 Sep 2016 14:57:27 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     zerons <sironhide0null@...il.com>
Cc:     liodot@...il.com, charrer@...critech.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/10] staging: slicoss: slic.h: add a macro
 IOMEM_GET_FIELDADDR to fix sparse warnings

A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Fri, Sep 16, 2016 at 06:41:38PM +0800, zerons wrote:
> these marcos are used to get the value or address of a member of a `__iomem` structure.
> GET_FIELDADDR is like &iomem_obj->field, and
> GET_FIELD32 is iomem_obj->u32val, GET_FIELD64 is iomem_obj->u64val.
> 
> If patch the .c file directly, the source gets into a mess.

But add the macro, and then use it, in the same patch, so we can verify
that this macro really is doing what you think it is doing, and so that
it is used at the same time (no need to add a macro that no one uses...

thanks,

greg k-h