linux-kernel - Re: [PATCH] swiotlb: remove unused swiotlb_map_sg and swiotlb_unmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160916151215.GD10617@char.us.oracle.com>
Date:   Fri, 16 Sep 2016 11:12:15 -0400
From:   Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To:     Christoph Hellwig <hch@....de>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] swiotlb: remove unused swiotlb_map_sg and
 swiotlb_unmap_sg functions

On Sun, Sep 11, 2016 at 06:34:18PM +0200, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <hch@....de>

Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
> ---
>  include/linux/swiotlb.h |  8 --------
>  lib/swiotlb.c           | 16 ----------------
>  2 files changed, 24 deletions(-)
> 
> diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h
> index 5f81f8a..f0d2589 100644
> --- a/include/linux/swiotlb.h
> +++ b/include/linux/swiotlb.h
> @@ -73,14 +73,6 @@ extern void swiotlb_unmap_page(struct device *hwdev, dma_addr_t dev_addr,
>  			       unsigned long attrs);
>  
>  extern int
> -swiotlb_map_sg(struct device *hwdev, struct scatterlist *sg, int nents,
> -	       enum dma_data_direction dir);
> -
> -extern void
> -swiotlb_unmap_sg(struct device *hwdev, struct scatterlist *sg, int nents,
> -		 enum dma_data_direction dir);
> -
> -extern int
>  swiotlb_map_sg_attrs(struct device *hwdev, struct scatterlist *sgl, int nelems,
>  		     enum dma_data_direction dir,
>  		     unsigned long attrs);
> diff --git a/lib/swiotlb.c b/lib/swiotlb.c
> index 22e13a0..5005316 100644
> --- a/lib/swiotlb.c
> +++ b/lib/swiotlb.c
> @@ -910,14 +910,6 @@ swiotlb_map_sg_attrs(struct device *hwdev, struct scatterlist *sgl, int nelems,
>  }
>  EXPORT_SYMBOL(swiotlb_map_sg_attrs);
>  
> -int
> -swiotlb_map_sg(struct device *hwdev, struct scatterlist *sgl, int nelems,
> -	       enum dma_data_direction dir)
> -{
> -	return swiotlb_map_sg_attrs(hwdev, sgl, nelems, dir, 0);
> -}
> -EXPORT_SYMBOL(swiotlb_map_sg);
> -
>  /*
>   * Unmap a set of streaming mode DMA translations.  Again, cpu read rules
>   * concerning calls here are the same as for swiotlb_unmap_page() above.
> @@ -938,14 +930,6 @@ swiotlb_unmap_sg_attrs(struct device *hwdev, struct scatterlist *sgl,
>  }
>  EXPORT_SYMBOL(swiotlb_unmap_sg_attrs);
>  
> -void
> -swiotlb_unmap_sg(struct device *hwdev, struct scatterlist *sgl, int nelems,
> -		 enum dma_data_direction dir)
> -{
> -	return swiotlb_unmap_sg_attrs(hwdev, sgl, nelems, dir, 0);
> -}
> -EXPORT_SYMBOL(swiotlb_unmap_sg);
> -
>  /*
>   * Make physical memory consistent for a set of streaming mode DMA translations
>   * after a transfer.
> -- 
> 2.1.4
>