linux-kernel - Re: [PATCH] ALSA: compress: fix some missing and misplaced \n in messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5h37kzoiz0.wl-tiwai@suse.de>
Date:   Fri, 16 Sep 2016 19:25:07 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     "Colin King" <colin.king@...onical.com>
Cc:     <alsa-devel@...a-project.org>, "Vinod Koul" <vinod.koul@...el.com>,
        <trivial@...nel.org>, "Jaroslav Kysela" <perex@...ex.cz>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: compress: fix some missing and misplaced \n in messages

On Fri, 16 Sep 2016 18:46:41 +0200,
Colin King wrote:
> 
> From: Colin Ian King <colin.king@...onical.com>
> 
> Fix a missing \n in a pr_debug message and move the \n to the end
> of a pr_err message.
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied, thanks.


Takashi

> ---
>  sound/core/compress_offload.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/core/compress_offload.c b/sound/core/compress_offload.c
> index 583d407..fec1dfd 100644
> --- a/sound/core/compress_offload.c
> +++ b/sound/core/compress_offload.c
> @@ -780,7 +780,7 @@ static int snd_compress_wait_for_drain(struct snd_compr_stream *stream)
>  	ret = wait_event_interruptible(stream->runtime->sleep,
>  			(stream->runtime->state != SNDRV_PCM_STATE_DRAINING));
>  	if (ret == -ERESTARTSYS)
> -		pr_debug("wait aborted by a signal");
> +		pr_debug("wait aborted by a signal\n");
>  	else if (ret)
>  		pr_debug("wait for drain failed with %d\n", ret);
>  
> @@ -962,7 +962,7 @@ static int snd_compress_dev_register(struct snd_device *device)
>  				  compr->card, compr->device,
>  				  &snd_compr_file_ops, compr, &compr->dev);
>  	if (ret < 0) {
> -		pr_err("snd_register_device failed\n %d", ret);
> +		pr_err("snd_register_device failed %d\n", ret);
>  		return ret;
>  	}
>  	return ret;
> -- 
> 2.9.3
> 
>