linux-kernel - Re: [PATCH] IB/rxe: fix GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6f9a4f4d-573b-a74e-28e2-213f119815e6@redhat.com>
Date:   Fri, 16 Sep 2016 13:55:28 -0400
From:   Doug Ledford <dledford@...hat.com>
To:     Moni Shoua <monis@...lanox.com>,
        Alexey Khoroshilov <khoroshilov@...ras.ru>
Cc:     Sean Hefty <sean.hefty@...el.com>,
        Hal Rosenstock <hal.rosenstock@...il.com>,
        linux-rdma <linux-rdma@...r.kernel.org>,
        linux-kernel@...r.kernel.org, ldv-project@...uxtesting.org
Subject: Re: [PATCH] IB/rxe: fix GFP_KERNEL in spinlock context

On 9/4/2016 6:01 AM, Moni Shoua wrote:
> On Fri, Sep 2, 2016 at 11:46 PM, Alexey Khoroshilov
> <khoroshilov@...ras.ru> wrote:
>> There is skb_clone(skb, GFP_KERNEL) in spinlock context
>> in rxe_rcv_mcast_pkt().
>>
>> Found by Linux Driver Verification project (linuxtesting.org).
>>
>> Signed-off-by: Alexey Khoroshilov <khoroshilov@...ras.ru>
>> ---
>>  drivers/infiniband/sw/rxe/rxe_recv.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/infiniband/sw/rxe/rxe_recv.c b/drivers/infiniband/sw/rxe/rxe_recv.c
>> index 3d464c23e08b..144d2f129fcd 100644
>> --- a/drivers/infiniband/sw/rxe/rxe_recv.c
>> +++ b/drivers/infiniband/sw/rxe/rxe_recv.c
>> @@ -312,7 +312,7 @@ static void rxe_rcv_mcast_pkt(struct rxe_dev *rxe, struct sk_buff *skb)
>>                  * make a copy of the skb to post to the next qp
>>                  */
>>                 skb_copy = (mce->qp_list.next != &mcg->qp_list) ?
>> -                               skb_clone(skb, GFP_KERNEL) : NULL;
>> +                               skb_clone(skb, GFP_ATOMIC) : NULL;
>>
>>                 pkt->qp = qp;
>>                 rxe_add_ref(qp);
>> --
>> 2.7.4
>>
> Acked-by: Moni Shoua <monis@...lanox.com>
> 

Thanks, applied.

-- 
Doug Ledford <dledford@...hat.com>
    GPG Key ID: 0E572FDD



Download attachment "signature.asc" of type "application/pgp-signature" (885 bytes)