linux-kernel - Re: [PATCH] mm/shmem.c: constify anon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.11.1609161203350.4175@eggly.anvils>
Date:   Fri, 16 Sep 2016 12:06:11 -0700 (PDT)
From:   Hugh Dickins <hughd@...gle.com>
To:     Rasmus Villemoes <linux@...musvillemoes.dk>,
        Andrew Morton <akpm@...ux-foundation.org>
cc:     Hugh Dickins <hughd@...gle.com>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/shmem.c: constify anon_ops

On Thu, 15 Sep 2016, Rasmus Villemoes wrote:

> Every other dentry_operations instance is const, and this one might as
> well be.
> 
> Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>

Indeed, thanks,

Acked-by: Hugh Dickins <hughd@...gle.com>

> ---
>  mm/shmem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/shmem.c b/mm/shmem.c
> index fd8b2b5741b1..693ffdc5899a 100644
> --- a/mm/shmem.c
> +++ b/mm/shmem.c
> @@ -4077,7 +4077,7 @@ EXPORT_SYMBOL_GPL(shmem_truncate_range);
>  
>  /* common code */
>  
> -static struct dentry_operations anon_ops = {
> +static const struct dentry_operations anon_ops = {
>  	.d_dname = simple_dname
>  };
>  
> -- 
> 2.1.4