linux-kernel - [tip regression] efi: Allow drivers to reserve boot services forever == toxic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1474005912.3930.10.camel@gmail.com>
Date:   Fri, 16 Sep 2016 08:05:12 +0200
From:   Mike Galbraith <umgwanakikbuti@...il.com>
To:     Matt Fleming <matt@...eblueprint.co.uk>
Cc:     Ingo Molnar <mingo@...e.hu>, LKML <linux-kernel@...r.kernel.org>
Subject: [tip regression]  efi: Allow drivers to reserve boot services
 forever == toxic

Hi Matt,

My workstation started instant rebooting with tip.  I bisected it to..

   efi/esrt: Use efi_mem_reserve() and avoid a kmalloc()

..but seems it's really $subject, as box works fine with the below.

---
 drivers/firmware/efi/efi.c |    1 +
 1 file changed, 1 insertion(+)

--- a/drivers/firmware/efi/efi.c
+++ b/drivers/firmware/efi/efi.c
@@ -415,6 +415,7 @@ void __init efi_mem_reserve(phys_addr_t
 {
 	if (!memblock_is_region_reserved(addr, size))
 		memblock_reserve(addr, size);
+	else
 
 	/*
 	 * Some architectures (x86) reserve all boot services ranges


No idea what's going boom down in efi_arch_mem_reserve().