linux-kernel - Re: [PATCH 2/4] serial: 8250: of: Load TX FIFO Load Size from DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2077078.euc60HfglH@wuerfel>
Date:   Fri, 16 Sep 2016 22:51:54 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     tthayer@...nsource.altera.com
Cc:     Rob Herring <robh@...nel.org>, gregkh@...uxfoundation.org,
        mark.rutland@....com, lftan@...era.com, jslaby@...e.com,
        peter@...leysoftware.com, andriy.shevchenko@...ux.intel.com,
        anton.wuerfel@....de, phillip.raffeck@....de,
        yegorslists@...glemail.com, matwey@....msu.ru,
        mail@...iej.szmigiero.name, peter.ujfalusi@...com,
        jonathanh@...dia.com, dongsheng.wang@....com,
        luis@...ethencourt.com, linux-kernel@...r.kernel.org,
        linux-serial@...r.kernel.org, devicetree@...r.kernel.org,
        tthayer.linux@...il.com, nios2-dev@...ts.rocketboards.org
Subject: Re: [PATCH 2/4] serial: 8250: of: Load TX FIFO Load Size from DT

On Friday, September 16, 2016 3:52:55 PM CEST Thor Thayer wrote:
> >
> >
> Yes, I originally had it implemented using that function but then I 
> realized the port8250.tx_loadsz is an unsigned int and therefore can 
> change size on different platforms.
> 
> The assignment handles that. In retrospect, I should probably change 
> this to a of_property_read_u8() anyway so that it won't cause compile 
> warnings in the smaller architectures.
> 
> Thank you for reviewing and the comments.

We don't support architectures with 'int' types other than 32 bits,
so the version that Rob suggested is guaranteed to work everywhere.

Using u8 properties seems like a bad idea in general, better stay
with 32-bit units for consistency.

	Arnd