linux-kernel - Re: [PATCH v3 1/3] nvme/scsi: Remove power management support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1474068791.10494.2.camel@linux.intel.com>
Date:   Fri, 16 Sep 2016 16:33:11 -0700
From:   J Freyensee <james_p_freyensee@...ux.intel.com>
To:     Christoph Hellwig <hch@....de>, Andy Lutomirski <luto@...nel.org>
Cc:     Jens Axboe <axboe@...com>, linux-kernel@...r.kernel.org,
        linux-nvme@...ts.infradead.org, Keith Busch <keith.busch@...el.com>
Subject: Re: [PATCH v3 1/3] nvme/scsi: Remove power management support

On Fri, 2016-09-16 at 10:33 +0200, Christoph Hellwig wrote:
> On Thu, Sep 15, 2016 at 10:24:19PM -0700, Andy Lutomirski wrote:
> > 
> > As far as I can tell, there is basically nothing correct about this
> > code.  It misinterprets npss (off-by-one).  It hardcodes a bunch of
> > power states, which is nonsense, because they're all just indices
> > into a table that software needs to parse.  It completely ignores
> > the distinction between operational and non-operational states.
> > And, until 4.8, if all of the above magically succeeded, it would
> > dereference a NULL pointer and OOPS.
> > 
> > Since this code appears to be useless, just delete it.
> 
> Yes, please!
> 
> Acked-by: Christoph Hellwig <hch@....de>

Acked-by: Jay Freyensee <james_p_freyensee@...ux.intel.com>