linux-kernel - Re: [tip regression] efi: Allow drivers to reserve boot services forever == toxic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160917195853.GG16797@codeblueprint.co.uk>
Date:   Sat, 17 Sep 2016 20:58:54 +0100
From:   Matt Fleming <matt@...eblueprint.co.uk>
To:     Mike Galbraith <umgwanakikbuti@...il.com>
Cc:     Ingo Molnar <mingo@...e.hu>, LKML <linux-kernel@...r.kernel.org>,
        linux-efi@...r.kernel.org, Peter Jones <pjones@...hat.com>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>
Subject: Re: [tip regression]  efi: Allow drivers to reserve boot services
 forever == toxic

On Fri, 16 Sep, at 06:34:55PM, Mike Galbraith wrote:
> On Fri, 2016-09-16 at 15:30 +0100, Matt Fleming wrote:
> > On Fri, 16 Sep, at 12:00:59PM, Mike Galbraith wrote:
> > > 
> > > Ok, here's the whole thing just in case.  Hope it's not too big.
> >  
> > [...]
> > 
> > > [    0.000000] esrt: Reserving ESRT space from 0x00000000def87998 to 0x00000000def879d0.
> > 
> > OK, that's 56 bytes and yet I realise that at no point in the
> > efi_mem_reserve() call path do we round up to the nearest page size
> > even though the EFI memory map only deals with EFI_PAGE_SIZE regions.
> > 
> > Could you try this patch?
> 
> No dice.  The numbers changed, but box still goes *poof*.
> 
> ---
>  arch/x86/platform/efi/quirks.c |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> --- a/arch/x86/platform/efi/quirks.c
> +++ b/arch/x86/platform/efi/quirks.c
> @@ -227,7 +227,11 @@ void __init efi_arch_mem_reserve(phys_ad
>  	efi_memmap_insert(&efi.memmap, new, &mr);
>  	early_memunmap(new, new_size);
>  
> +#if 0
>  	efi_memmap_install(new_phys, num_entries);
> +#else
> +	printk(KERN_DEBUG "MIKE efi_memmap_install(0x%Lx, %d);\n", new_phys, num_entries);
> +#endif
>  }
>  
>  /*
> 
> homer:..debug/tracing # journalctl|grep MIKE
> virgin+above
> Sep 16 15:51:15 homer kernel: MIKE efi_memmap_install(0x9d640, 51);
> Sep 16 15:55:07 homer kernel: MIKE efi_memmap_install(0x9d640, 51);
> +patch+above
> Sep 16 18:13:46 homer kernel: MIKE efi_memmap_install(0x9d600, 53);

These addresses are pretty low. Can you try the hacky patch plus
Ricardo's change in commit 3dad6f7f6975 ("x86/efi: Defer efi_esrt_init
until after memblock_x86_fill"). He fixed a bug where it's possible to
run out of memblock regions.