linux-kernel - [PATCH -next] vme: fake: remove unexpected unlock in fake_master

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sat, 17 Sep 2016 01:57:34 +0000
From:   Wei Yongjun <weiyj.lk@...il.com>
To:     Martyn Welch <martyn@...chs.me.uk>,
        Manohar Vanga <manohar.vanga@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Arnd Bergmann <arnd@...db.de>
Cc:     Wei Yongjun <weiyongjun1@...wei.com>, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH -next] vme: fake: remove unexpected unlock in fake_master_set()

From: Wei Yongjun <weiyongjun1@...wei.com>

image->lock is unlocked in some error handling path without take the
lock, so remove those unexpected unlock.

Fixes: 658bcdae9c67 ("vme: Adding Fake VME driver")
Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
---
 drivers/vme/bridges/vme_fake.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/vme/bridges/vme_fake.c b/drivers/vme/bridges/vme_fake.c
index ebf35d3..4b2613d 100644
--- a/drivers/vme/bridges/vme_fake.c
+++ b/drivers/vme/bridges/vme_fake.c
@@ -273,7 +273,6 @@ static int fake_master_set(struct vme_master_resource *image, int enabled,
 	}
 
 	if (size & 0xFFFF) {
-		spin_unlock(&image->lock);
 		pr_err("Invalid size alignment\n");
 		retval = -EINVAL;
 		goto err_window;
@@ -292,7 +291,6 @@ static int fake_master_set(struct vme_master_resource *image, int enabled,
 	case VME_D32:
 		break;
 	default:
-		spin_unlock(&image->lock);
 		pr_err("Invalid data width\n");
 		retval = -EINVAL;
 		goto err_dwidth;
@@ -311,7 +309,6 @@ static int fake_master_set(struct vme_master_resource *image, int enabled,
 	case VME_USER4:
 		break;
 	default:
-		spin_unlock(&image->lock);
 		pr_err("Invalid address space\n");
 		retval = -EINVAL;
 		goto err_aspace;