linux-kernel - Re: [PATCH] avr32: fix 'undefined reference to `___copy_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160918094643.GA25728@samfundet.no>
Date:   Sun, 18 Sep 2016 11:46:43 +0200
From:   Hans-Christian Noren Egtvedt <egtvedt@...fundet.no>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Håvard Skinnemoen <hskinnemoen@...il.com>,
        Linux Kernel <linux-kernel@...r.kernel.org>,
        Al Viro <viro@...iv.linux.org.uk>
Subject: Re: [PATCH] avr32: fix 'undefined reference to `___copy_from_user'

Around Sat 17 Sep 2016 13:09:17 -0700 or thereabout, Guenter Roeck wrote:
> On 09/17/2016 09:52 AM, Håvard Skinnemoen wrote:
>>On Sat, Sep 17, 2016 at 7:56 AM, Guenter Roeck <linux@...ck-us.net> wrote:
>>>avr32 builds fail with:
>>>
>>>arch/avr32/kernel/built-in.o: In function `arch_ptrace':
>>>(.text+0x650): undefined reference to `___copy_from_user'
>>>arch/avr32/kernel/built-in.o:(___ksymtab+___copy_from_user+0x0): undefined
>>>reference to `___copy_from_user'
>>>kernel/built-in.o: In function `proc_doulongvec_ms_jiffies_minmax':
>>>(.text+0x5dd8): undefined reference to `___copy_from_user'
>>>kernel/built-in.o: In function `proc_dointvec_minmax_sysadmin':
>>>sysctl.c:(.text+0x6174): undefined reference to `___copy_from_user'
>>>kernel/built-in.o: In function `ptrace_has_cap':
>>>ptrace.c:(.text+0x69c0): undefined reference to `___copy_from_user'
>>>kernel/built-in.o:ptrace.c:(.text+0x6b90): more undefined references to
>>>`___copy_from_user' follow
>>>
>>>Fixes: 8630c32275ba ("avr32: fix copy_from_user()")
>>>Cc: Al Viro <viro@...iv.linux.org.uk>
>>>Signed-off-by: Guenter Roeck <linux@...ck-us.net>
>>
>>Right, gmail loves HTML. Let me try this again...
>>
>>Acked-by: Havard Skinnemoen <hskinnemoen@...il.com>

Acked-by: Hans-Christian Noren Egtvedt <egtvedt@...fundet.no>

>>Thanks!
>>
> You are welcome ... I'll wait until tomorrow to see if Al wants to send this
> patch and the patch for the openrisc failure to Linus; if I don't hear back,
> I'll do it myself.

Thanks, I have no other fixes for AVR32. But let me know if you want me to
push it through linux-avr32.

Why did not Al add Håvard/me to CC in the first place? That way we might have
avoided this build break in the first place?

-- 
Best regards,
Hans-Christian Noren Egtvedt