linux-kernel - [PATCH] staging: ks7010: clean function declarations in ks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sun, 18 Sep 2016 19:18:24 +0800
From:   Baoyou Xie <baoyou.xie@...aro.org>
To:     gregkh@...uxfoundation.org, wsa+renesas@...g-engineering.com,
        colin.king@...onical.com, hofrat@...dl.org,
        karniksayli1995@...il.com
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        arnd@...db.de, baoyou.xie@...aro.org, xie.baoyou@....com.cn
Subject: [PATCH] staging: ks7010: clean function declarations in ks_hostif.c up

We get 2 warnings when building kernel with W=1:
drivers/staging/ks7010/ks7010_sdio.c:152:6: warning: no previous prototype for 'ks_wlan_hw_wakeup_request' [-Wmissing-prototypes]
drivers/staging/ks7010/ks7010_sdio.c:255:5: warning: no previous prototype for 'ks_wlan_hw_power_save' [-Wmissing-prototypes]

In fact, both functions are declared in
drivers/staging/ks7010/ks_hostif.c, but should
be declared in a header file, thus can be recognized in other file.

So this patch adds the declarations into
drivers/staging/ks7010/ks_wlan.h.

Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>
---
 drivers/staging/ks7010/ks_hostif.c | 3 ---
 drivers/staging/ks7010/ks_wlan.h   | 2 ++
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
index aacb93e..49a81d2 100644
--- a/drivers/staging/ks7010/ks_hostif.c
+++ b/drivers/staging/ks7010/ks_hostif.c
@@ -25,9 +25,6 @@ extern int ks_wlan_hw_tx(struct ks_wlan_private *priv, void *p,
 			 void (*complete_handler) (void *arg1, void *arg2),
 			 void *arg1, void *arg2);
 
-extern void ks_wlan_hw_wakeup_request(struct ks_wlan_private *priv);
-extern int ks_wlan_hw_power_save(struct ks_wlan_private *priv);
-
 /* macro */
 #define inc_smeqhead(priv) \
         ( priv->sme_i.qhead = (priv->sme_i.qhead + 1) % SME_EVENT_BUFF_SIZE )
diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h
index 936222b..54a1531 100644
--- a/drivers/staging/ks7010/ks_wlan.h
+++ b/drivers/staging/ks7010/ks_wlan.h
@@ -501,6 +501,8 @@ struct ks_wlan_private {
 
 extern int ks_wlan_net_start(struct net_device *dev);
 extern int ks_wlan_net_stop(struct net_device *dev);
+void ks_wlan_hw_wakeup_request(struct ks_wlan_private *priv);
+int ks_wlan_hw_power_save(struct ks_wlan_private *priv);
 
 void send_packet_complete(void *, void *);
 
-- 
2.7.4