linux-kernel - Re: [PATCH v2] sched/core: remove unnecessary initialization in sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ae1ee8fe-abf4-7771-e99a-c57f1c0bdf3c@gmail.com>
Date:   Sun, 18 Sep 2016 09:59:08 +0800
From:   Cheng Chao <cs.os.kernel@...il.com>
To:     peterz@...radead.org
Cc:     mingo@...hat.com, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org
Subject: Re: [PATCH v2] sched/core: remove unnecessary initialization in
 sched_init()

Hi Peter,

  Would you please review this patch? thanks.

Cheng

on 09/14/2016 10:23 AM, Cheng Chao wrote:
> init_idle() is called immediately after current->sched_class
> = &fair_sched_class, init_idle() sets current->sched_class
> = &idle_sched_class.
> 
> Signed-off-by: Cheng Chao <cs.os.kernel@...il.com>
> Cc: stable@...r.kernel.org
> ---
>  kernel/sched/core.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index a0086a5..ed4f4fe 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -7557,11 +7557,6 @@ void __init sched_init(void)
>  	enter_lazy_tlb(&init_mm, current);
>  
>  	/*
> -	 * During early bootup we pretend to be a normal task:
> -	 */
> -	current->sched_class = &fair_sched_class;
> -
> -	/*
>  	 * Make us the idle thread. Technically, schedule() should not be
>  	 * called from this thread, however somewhere below it might be,
>  	 * but because we are the idle thread, we just pick up running again
>