linux-kernel - Re: [PATCH 06/10] ARM: dts: exynos: Fix invalid GIC interrupt flags in exynos5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c64744b1-eab5-350b-7f87-86c159abffb6@osg.samsung.com>
Date:   Sun, 18 Sep 2016 11:17:04 -0400
From:   Javier Martinez Canillas <javier@....samsung.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>,
        Kukjin Kim <kgene@...nel.org>, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Marek Szyprowski <m.szyprowski@...sung.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Alban Browaeys <alban.browaeys@...il.com>,
        Marc Zyngier <marc.zyngier@....com>
Subject: Re: [PATCH 06/10] ARM: dts: exynos: Fix invalid GIC interrupt flags
 in exynos5

Hello Krzysztof,

On 09/16/2016 03:42 PM, Krzysztof Kozlowski wrote:
> Interrupt of type IRQ_TYPE_NONE is not allowed for GIC interrupts and
> generates an error:
> 	genirq: Setting trigger mode 0 for irq 16 failed (gic_set_type+0x0/0x68)
> 
> The GIC requires shared interrupts to be edge rising or level high.
> Platform declares support for both.  Choose level high everywhere.
> 
> Reported-by: Marek Szyprowski <m.szyprowski@...sung.com>
> Reported-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Reported-by: Alban Browaeys <alban.browaeys@...il.com>
> Cc: Marc Zyngier <marc.zyngier@....com>
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> ---

I tested this patch on an Exynos5800 Peach Pi Chromebook and
an Exynos5422 Odroid XU4 board and no regressions were found.

Tested-by: Javier Martinez Canillas <javier@....samsung.com>

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America