linux-kernel - Re: [PATCH 5/7] openrisc: Support both old (or32) and new (or1k) toolchain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8ef63a71-81ed-2a0c-e204-666f7fba5e4c@roeck-us.net>
Date:   Sun, 18 Sep 2016 08:26:30 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Stafford Horne <shorne@...il.com>, Jonas Bonn <jonas@...thpole.se>,
        Stefan Kristiansson <stefan.kristiansson@...nalahti.fi>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/7] openrisc: Support both old (or32) and new (or1k)
 toolchain

On 09/16/2016 07:43 AM, Stafford Horne wrote:
> From: Guenter Roeck <linux@...ck-us.net>
>
> The output file format for or1k has changed from "elf32-or32"
> to "elf32-or1k". Select the correct output format automatically
> to be able to compile the kernel with both toolchain variants.
>
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> Signed-off-by: Stafford Horne <shorne@...il.com>

I tested your entire series with my qemu setup. Works for me, so for the series:

Tested-by: Guenter Roeck <linux@...ck-us.net>

If you plan to handle openrisc going forward, it would be great if you could
consider updating MAINTAINERS. The web site and git repository have been unreachable
for a long time.

Thanks,
Guenter

> ---
>  arch/openrisc/kernel/vmlinux.lds.S | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/arch/openrisc/kernel/vmlinux.lds.S b/arch/openrisc/kernel/vmlinux.lds.S
> index d936de4..4a72d5d 100644
> --- a/arch/openrisc/kernel/vmlinux.lds.S
> +++ b/arch/openrisc/kernel/vmlinux.lds.S
> @@ -30,7 +30,13 @@
>  #include <asm/cache.h>
>  #include <asm-generic/vmlinux.lds.h>
>
> -OUTPUT_FORMAT("elf32-or32", "elf32-or32", "elf32-or32")
> +#ifdef __OR1K__
> +#define __OUTPUT_FORMAT        "elf32-or1k"
> +#else
> +#define __OUTPUT_FORMAT        "elf32-or32"
> +#endif
> +
> +OUTPUT_FORMAT(__OUTPUT_FORMAT, __OUTPUT_FORMAT, __OUTPUT_FORMAT)
>  jiffies = jiffies_64 + 4;
>
>  SECTIONS
>