linux-kernel - Re: [PATCH] hwmon: (adt7470) No need for additional synchronization on kthread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 18 Sep 2016 10:10:13 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Daniel Wagner <wagi@...om.org>, linux-kernel@...r.kernel.org
Cc:     Daniel Wagner <daniel.wagner@...-carit.de>,
        "Darrick J . Wong" <djwong@...ibm.com>,
        Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org
Subject: Re: [PATCH] hwmon: (adt7470) No need for additional synchronization
 on kthread_stop()

On 09/16/2016 01:07 AM, Daniel Wagner wrote:
> From: Daniel Wagner <daniel.wagner@...-carit.de>
>
> The kthread_stop() waits for the thread to exit. There is no need for an
> additional synchronization needed to join on the kthread.
>
> The completation was added by 89fac11cb3e7 ("adt7470: make automatic fan
> control really work").
>
> Signed-off-by: Daniel Wagner <daniel.wagner@...-carit.de>
> Cc: Darrick J. Wong <djwong@...ibm.com>
> Cc: Jean Delvare <jdelvare@...e.com>
> Cc: Guenter Roeck <linux@...ck-us.net>
> Cc: linux-hwmon@...r.kernel.org

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/adt7470.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/hwmon/adt7470.c b/drivers/hwmon/adt7470.c
> index f5da39a..f5d618c 100644
> --- a/drivers/hwmon/adt7470.c
> +++ b/drivers/hwmon/adt7470.c
> @@ -170,7 +170,6 @@ struct adt7470_data {
>  	u8			pwm_auto_temp[ADT7470_PWM_COUNT];
>
>  	struct task_struct	*auto_update;
> -	struct completion	auto_update_stop;
>  	unsigned int		auto_update_interval;
>  };
>
> @@ -271,7 +270,6 @@ static int adt7470_update_thread(void *p)
>  		msleep_interruptible(data->auto_update_interval);
>  	}
>
> -	complete_all(&data->auto_update_stop);
>  	return 0;
>  }
>
> @@ -1256,7 +1254,6 @@ static int adt7470_probe(struct i2c_client *client,
>  	if (IS_ERR(hwmon_dev))
>  		return PTR_ERR(hwmon_dev);
>
> -	init_completion(&data->auto_update_stop);
>  	data->auto_update = kthread_run(adt7470_update_thread, client, "%s",
>  					dev_name(hwmon_dev));
>  	if (IS_ERR(data->auto_update)) {
> @@ -1271,7 +1268,6 @@ static int adt7470_remove(struct i2c_client *client)
>  	struct adt7470_data *data = i2c_get_clientdata(client);
>
>  	kthread_stop(data->auto_update);
> -	wait_for_completion(&data->auto_update_stop);
>  	return 0;
>  }
>
>