linux-kernel - Re: [PATCH] sysfs print name of undiscoverable attribute group as well

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160918175751.jt6zlwlwf6j4fble@linux-x5ow.site>
Date:   Sun, 18 Sep 2016 19:57:51 +0200
From:   Johannes Thumshirn <jthumshirn@...e.de>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Linux Kernel Mailinglist <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sysfs print name of undiscoverable attribute group as
 well

On Sun, Sep 18, 2016 at 09:36:02AM +0200, Greg KH wrote:
> On Thu, Sep 15, 2016 at 09:44:06PM +0200, Johannes Thumshirn wrote:
> > Print the name of an undiscoverable attribute group as well, not just
> > the pointer's address.
> 
> Shouldn't we just drop the pointer address and use the name?  It's bad
> form to be printing kernel addresses to the syslog these days given that
> it is a security information leak :(

Probably yes. Given it's not etremely helpful when debugging either
I'll send a v2 with the address dropped.

Thanks,
	Johannes

-- 
Johannes Thumshirn                                          Storage
jthumshirn@...e.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850