linux-kernel - Re: [PATCH] staging: lustre: lmv: add missing function declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.20.1609182152220.31599@casper.infradead.org>
Date:   Sun, 18 Sep 2016 21:53:46 +0100 (BST)
From:   James Simmons <jsimmons@...radead.org>
To:     Arnd Bergmann <arnd@...db.de>
cc:     Baoyou Xie <baoyou.xie@...aro.org>, oleg.drokin@...el.com,
        andreas.dilger@...el.com, gregkh@...uxfoundation.org,
        di.wang@...el.com, john.hammond@...el.com, fan.yong@...el.com,
        lustre-devel@...ts.lustre.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, xie.baoyou@....com.cn
Subject: Re: [PATCH] staging: lustre: lmv: add missing function declaration


> On Sunday, September 18, 2016 8:43:18 PM CEST James Simmons wrote:
> > 
> > Nak. I'm not seeing this error with W=1. Also if you look
> > lmv_pack_md() is only used in lmv_obd.c and the function
> > appears early in the file before it is used, so no prototype
> > missing errors should happen. 
> 
> So it should be marked "static" and the EXPORT_SYMBOL() removed,
> right?

Already done. See patch

[PATCH 109/124] staging: lustre: misc: remove unnecessary EXPORT_SYMBOL

which is from Frank Zago which I just pushed to Greg.