linux-kernel - [PATCH] dcache: fix implicit wait.h include in <linux/dcache.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sun, 18 Sep 2016 17:51:50 -0400
From:   Paul Gortmaker <paul.gortmaker@...driver.com>
To:     <linux-kernel@...r.kernel.org>
CC:     Paul Gortmaker <paul.gortmaker@...driver.com>,
        Al Viro <viro@...iv.linux.org.uk>
Subject: [PATCH] dcache: fix implicit wait.h include in <linux/dcache.h>

To fix:

  In file included from fs/notify/fsnotify.c:19:0:
  ./include/linux/dcache.h:103:3: error: unknown type name ‘wait_queue_head_t’
     wait_queue_head_t *d_wait; /* in-lookup ones only */
     ^
  ./include/linux/dcache.h:233:6: error: unknown type name ‘wait_queue_head_t’
        wait_queue_head_t *);
        ^
  make[2]: *** [fs/notify/fsnotify.o] Error 1

The same fail appears in file included from security/security.c:15:0:

This was observed in -rt, but it is quite possible the same issue will
appear for certain configs or arch builds on mainline as well.

Fixes: d9171b934526 ("parallel lookups machinery, part 4 (and last)")
Cc: Al Viro <viro@...iv.linux.org.uk>
Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>

diff --git a/include/linux/dcache.h b/include/linux/dcache.h
index 5ff3e9a4fe5f..b719cb8b6b5d 100644
--- a/include/linux/dcache.h
+++ b/include/linux/dcache.h
@@ -3,6 +3,7 @@
 
 #include <linux/atomic.h>
 #include <linux/list.h>
+#include <linux/wait.h>
 #include <linux/rculist.h>
 #include <linux/rculist_bl.h>
 #include <linux/spinlock.h>
-- 
2.5.0