linux-kernel - Re: [PATCH -next] drm/i915: Fix non static symbol warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87y42o761v.fsf@intel.com>
Date:   Mon, 19 Sep 2016 09:33:00 +0300
From:   Jani Nikula <jani.nikula@...ux.intel.com>
To:     Wei Yongjun <weiyj.lk@...il.com>,
        Daniel Vetter <daniel.vetter@...el.com>,
        David Airlie <airlied@...ux.ie>,
        Mika Kahola <mika.kahola@...el.com>
Cc:     Wei Yongjun <weiyongjun1@...wei.com>,
        intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] drm/i915: Fix non static symbol warning

On Sat, 17 Sep 2016, Wei Yongjun <weiyj.lk@...il.com> wrote:
> From: Wei Yongjun <weiyongjun1@...wei.com>
>
> Fixes the following sparse warning:
>
> drivers/gpu/drm/i915/intel_dp.c:1527:5: warning:
>  symbol 'intel_dp_compute_bpp' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> ---
>  drivers/gpu/drm/i915/intel_dp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 69cee9b..acd0c51 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -1524,8 +1524,8 @@ void intel_dp_compute_rate(struct intel_dp *intel_dp, int port_clock,
>  	}
>  }
>  
> -int intel_dp_compute_bpp(struct intel_dp *intel_dp,
> -			 struct intel_crtc_state *pipe_config)
> +static int intel_dp_compute_bpp(struct intel_dp *intel_dp,
> +				struct intel_crtc_state *pipe_config)

Already fixed upstream.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center