linux-kernel - Re: [PATCH -next] ASoC: sti: fix missing clk_disable_unprepare() on error in uni_player

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <357834f2-bae9-c481-785e-b5d4dd6f152b@st.com>
Date:   Mon, 19 Sep 2016 09:27:03 +0200
From:   Arnaud Pouliquen <arnaud.pouliquen@...com>
To:     Wei Yongjun <weiyj.lk@...il.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Moise GERGAUD <moise.gergaud@...com>
CC:     Wei Yongjun <weiyongjun1@...wei.com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] ASoC: sti: fix missing clk_disable_unprepare() on
 error in uni_player_start()

Hello Wei,

Acked-by: Arnaud Pouliquen <arnaud.pouliquen@...com>

Thanks!

On 09/17/2016 03:34 AM, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@...wei.com>
> 
> Fix the missing clk_disable_unprepare() before return
> from uni_player_start() in the error handling case.
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> ---
>  sound/soc/sti/uniperif_player.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/soc/sti/uniperif_player.c b/sound/soc/sti/uniperif_player.c
> index 645e415..1bc8ebc 100644
> --- a/sound/soc/sti/uniperif_player.c
> +++ b/sound/soc/sti/uniperif_player.c
> @@ -893,8 +893,10 @@ static int uni_player_start(struct uniperif *player)
>  	SET_UNIPERIF_SOFT_RST_SOFT_RST(player);
>  
>  	ret = reset_player(player);
> -	if (ret < 0)
> +	if (ret < 0) {
> +		clk_disable_unprepare(player->clk);
>  		return ret;
> +	}
>  
>  	/*
>  	 * Does not use IEC61937 features of the uniperipheral hardware.
>