linux-kernel - Re: [PATCH] pinctrl: nomadik: don't default-flag IRQs as falling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <57DFA6B8.5070306@arm.com>
Date:   Mon, 19 Sep 2016 09:50:00 +0100
From:   Marc Zyngier <marc.zyngier@....com>
To:     Linus Walleij <linus.walleij@...aro.org>,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Cc:     linux-gpio@...r.kernel.org
Subject: Re: [PATCH] pinctrl: nomadik: don't default-flag IRQs as falling

On 19/09/16 09:22, Linus Walleij wrote:
> There is no point in adding any default trigger for these
> GPIO interrupts: the device tree should contain all trigger
> information and the platforms using the driver boots
> exclusively from device tree.
> 
> Also the boot log is nagging me to fix this:
> 
> [    0.771057] ------------[ cut here ]------------
> [    0.775695] WARNING: CPU: 0 PID: 1 at
>    ../drivers/gpio/gpiolib.c:1622 _gpiochip_irqchip_add+0x138/0x160
> [    0.785034] /soc/gpio@...2e000: Ignoring 2 default trigger
> (...)
> [    0.942962] gpio 8012e000.gpio: at address e08f8000
> (etc ad nauseam)
> 
> Suggested-by: Marc Zyngier <marc.zyngier@....com>
> Signed-off-by: Linus Walleij <linus.walleij@...aro.org>
> ---
>  drivers/pinctrl/nomadik/pinctrl-nomadik.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/nomadik/pinctrl-nomadik.c b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
> index 205fb399268a..d318ca055489 100644
> --- a/drivers/pinctrl/nomadik/pinctrl-nomadik.c
> +++ b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
> @@ -1177,7 +1177,7 @@ static int nmk_gpio_probe(struct platform_device *dev)
>  				   irqchip,
>  				   0,
>  				   handle_edge_irq,
> -				   IRQ_TYPE_EDGE_FALLING);
> +				   IRQ_TYPE_NONE);
>  	if (ret) {
>  		dev_err(&dev->dev, "could not add irqchip\n");
>  		gpiochip_remove(&nmk_chip->chip);
> 

Acked-by: Marc Zyngier <marc.zyngier@....com>

	M.
-- 
Jazz is not dead. It just smells funny...