linux-kernel - Re: [tip regression] efi: Allow drivers to reserve boot services forever == toxic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160919085547.GA11118@leverpostej>
Date:   Mon, 19 Sep 2016 09:56:36 +0100
From:   Mark Rutland <mark.rutland@....com>
To:     Mike Galbraith <umgwanakikbuti@...il.com>
Cc:     Matt Fleming <matt@...eblueprint.co.uk>,
        Ingo Molnar <mingo@...e.hu>,
        LKML <linux-kernel@...r.kernel.org>, linux-efi@...r.kernel.org,
        Peter Jones <pjones@...hat.com>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>
Subject: Re: [tip regression]  efi: Allow drivers to reserve boot services
 forever == toxic

On Fri, Sep 16, 2016 at 08:26:16PM +0200, Mike Galbraith wrote:
> On Fri, 2016-09-16 at 15:45 +0100, Mark Rutland wrote:
> 
> > > diff --git a/arch/x86/platform/efi/quirks.c
> > > b/arch/x86/platform/efi/quirks.c
> > > index f14b7a9da24b..e881b4b2ffd6 100644
> > > --- a/arch/x86/platform/efi/quirks.c
> > > +++ b/arch/x86/platform/efi/quirks.c
> > > @@ -201,8 +201,10 @@ void __init efi_arch_mem_reserve(phys_addr_t
> > > addr, u64 size)
> > >  		return;
> > >  	}
> > >  
> > > +	size = round_up(size, EFI_PAGE_SIZE);
> > 
> > i.e. have:
> > 
> > 	size += addr % EFI_PAGE_SIZE;
> > 	size = round_up(size, EFI_PAGE_SIZE);
> > 	addr = round_down(base, EFI_PAGE_SIZE);
>                           ^^^^
> 
> s/base/addr did work, was that what you meant to write, or am I lucky? 

That was what I meant to write, though the two statements aren't
necessarily mutually exclusive. ;)

I'll have to leave it to you and Matt to figure out what the real
solution is -- I'm not familiar with this code and was just
pattern-matching.

Thanks,
Mark.