linux-kernel - [PATCH] i2c: fix device_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1609191146130.3203@hadrien>
Date:   Mon, 19 Sep 2016 11:47:50 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     Joel Stanley <joel@....id.au>
cc:     kbuild-all@...org, Jeremy Kerr <jk@...abs.org>,
        Milton Miller <miltonm@...ibm.com>,
        Wolfram Sang <wsa@...-dreams.de>, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH] i2c: fix device_node_continue.cocci warnings

 Device node iterators put the previous value of the index variable, so an
 explicit put causes a double put.

Generated by: scripts/coccinelle/iterators/device_node_continue.cocci

Signed-off-by: Julia Lawall <julia.lawall@...6.fr>
Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
---

Please take the patch only if it's a positive warning. Thanks!

I haven't checked anything more that what is shown in the patch.

julia

 i2c-aspeed.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/i2c/busses/i2c-aspeed.c
+++ b/drivers/i2c/busses/i2c-aspeed.c
@@ -862,7 +862,6 @@ static int ast_i2c_probe_controller(stru
 			continue;

 		of_platform_device_create(np, bus_id, &pdev->dev);
-		of_node_put(np);
 	}

 	return 0;