linux-kernel - Re: [PATCH] drm/amdgpu: add function declaration in amdgpu.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 19 Sep 2016 12:03:31 +0200
From:   Christian König <christian.koenig@....com>
To:     Baoyou Xie <baoyou.xie@...aro.org>,
        "Deucher, Alexander" <Alexander.Deucher@....com>,
        "airlied@...ux.ie" <airlied@...ux.ie>,
        "Zhou, David(ChunMing)" <David1.Zhou@....com>,
        "Liu, Monk" <Monk.Liu@....com>, "Zhu, Rex" <Rex.Zhu@....com>,
        "Huang, JinHuiEric" <JinHuiEric.Huang@....com>,
        "Cui, Flora" <Flora.Cui@....com>
CC:     "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "arnd@...db.de" <arnd@...db.de>,
        "xie.baoyou@....com.cn" <xie.baoyou@....com.cn>
Subject: Re: [PATCH] drm/amdgpu: add function declaration in amdgpu.h

Am 18.09.2016 um 16:29 schrieb Baoyou Xie:
> We get 2 warnings when building kernel with W=1:
> drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c:502:10: warning: no previous prototype for 'init_cond_exec' [-Wmissing-prototypes]
> drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c:514:6: warning: no previous prototype for 'patch_cond_exec' [-Wmissing-prototypes]
>
> In fact, both functions are not declared in any files.
>
> So this patch declares them in drivers/gpu/drm/amd/amdgpu/amdgpu.h.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>

NAK, IIRC Alex posted a patch last week to remove those two.

Regards,
Christian.

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> index 8e3d9b2..7b71cbe 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> @@ -396,6 +396,8 @@ int amdgpu_fence_emit(struct amdgpu_ring *ring, struct fence **fence);
>   void amdgpu_fence_process(struct amdgpu_ring *ring);
>   int amdgpu_fence_wait_empty(struct amdgpu_ring *ring);
>   unsigned amdgpu_fence_count_emitted(struct amdgpu_ring *ring);
> +unsigned int init_cond_exec(struct amdgpu_ring *ring);
> +void patch_cond_exec(struct amdgpu_ring *ring, unsigned int offset);
>   
>   /*
>    * BO.