linux-kernel - [PATCH v3] leds: triggers: Check return value of kobject_uevent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-id: <1474282344-11496-1-git-send-email-j.anaszewski@samsung.com>
Date:   Mon, 19 Sep 2016 12:52:24 +0200
From:   Jacek Anaszewski <j.anaszewski@...sung.com>
To:     linux-leds@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, greg@...ah.com, joe@...ches.com,
        Jacek Anaszewski <j.anaszewski@...sung.com>
Subject: [PATCH v3] leds: triggers: Check return value of kobject_uevent_env()

Log error message if kobject_uevent_env() fails in led_trigger_set().

Signed-off-by: Jacek Anaszewski <j.anaszewski@...sung.com>
---
Changes from v1:
- switched to using dev_err() instead of pr_err()
Changes from v2:
- switched to using __func__ instead of explicit function name,
  to simplify code maintenance

 drivers/leds/led-triggers.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/leds/led-triggers.c b/drivers/leds/led-triggers.c
index c7a38d4..431123b 100644
--- a/drivers/leds/led-triggers.c
+++ b/drivers/leds/led-triggers.c
@@ -141,7 +141,9 @@ void led_trigger_set(struct led_classdev *led_cdev, struct led_trigger *trig)
 	if (event) {
 		envp[0] = event;
 		envp[1] = NULL;
-		kobject_uevent_env(&led_cdev->dev->kobj, KOBJ_CHANGE, envp);
+		if (kobject_uevent_env(&led_cdev->dev->kobj, KOBJ_CHANGE, envp))
+			dev_err(led_cdev->dev,
+				"%s: Error sending uevent\n", __func__);
 		kfree(event);
 	}
 }
-- 
1.9.1