linux-kernel - Re: [PATCH] x86/vdso: Add ARCH_MAP_VDSO_X32 if CONFIG_X86_X32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2f791b53-1216-7b96-11a6-66dcb8961605@virtuozzo.com>
Date:   Mon, 19 Sep 2016 14:33:12 +0300
From:   Dmitry Safonov <dsafonov@...tuozzo.com>
To:     Vinson Lee <vlee@...edesktop.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>, <x86@...nel.org>,
        Andy Lutomirski <luto@...nel.org>,
        Borislav Petkov <bp@...e.de>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Brian Gerst <brgerst@...il.com>
CC:     <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86/vdso: Add ARCH_MAP_VDSO_X32 if CONFIG_X86_X32_ABI.

On 09/17/2016 03:51 AM, Vinson Lee wrote:
> vdso_image_x32 is generated if CONFIG_X86_X32_ABI.
>
> This patch fixes this build error on CentOS 6.8 with gcc 4.4.
>
>   LD      init/built-in.o
> arch/x86/built-in.o: In function `do_arch_prctl':
> (.text+0x27466): undefined reference to `vdso_image_x32'
> arch/x86/built-in.o: In function `do_arch_prctl':
> (.text+0x27477): undefined reference to `vdso_image_x32'
>
> Fixes: 2eefd8789698 ("x86/arch_prctl/vdso: Add ARCH_MAP_VDSO_*")
> Signed-off-by: Vinson Lee <vlee@...edesktop.org>

Thanks!
Reviewed-by: Dmitry Safonov <dsafonov@...tuozzo.com>

Ifdeffery in arch/x86/include/asm/vdso.h dazzled my eyes.

-- 
              Dmitry