linux-kernel - Re: [PATCH] arm64/efi: efi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <59201151-2fb3-2dd2-503e-d8e30fa0a77c@huawei.com>
Date:   Mon, 19 Sep 2016 20:29:39 +0800
From:   Yisheng Xie <xieyisheng1@...wei.com>
To:     Matt Fleming <matt@...eblueprint.co.uk>
CC:     Will Deacon <will.deacon@....com>, <mingo@...nel.org>,
        <guohanjun@...wei.com>, <mark.rutland@....com>,
        <catalin.marinas@....com>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-efi@...r.kernel.org>, <ard.biesheuvel@...aro.org>
Subject: Re: [PATCH] arm64/efi: efi_init error handling fix



On 2016/9/13 19:18, Matt Fleming wrote:
> On Wed, 07 Sep, at 07:15:48PM, Yisheng Xie wrote:
>>
>>
>> On 2016/9/5 21:57, Matt Fleming wrote:
>>> On Fri, 02 Sep, at 11:26:18AM, Will Deacon wrote:
>>>> On Fri, Sep 02, 2016 at 06:18:39PM +0800, Xie Yisheng wrote:
>>>>> From: Yisheng Xie <xieyisheng1@...wei.com>
>>>>>
>>>
>>> This should be a call to efi_memmap_unmap() because the EFI_MEMMAP
>>> flag also needs clearing.
>>>
>> Hi Matt,
>> Thanks for your reply.
>> You mean call the function efi_unmap_memmap() like x86?
>>
>> however, it seems no need to clear EFI_MEMMAP here. For arm*, the flag
>> EFI_MEMMAP is set in function reserve_regions(), which is called
>> only when uefi_init() return 0:
>>
>> efi_init()
>>    -> reserve_regions()
>>        -> set_bit(EFI_MEMMAP, &efi.flags);
> 
> This patch should be against the 'next' branch here,
> 
>   https://git.kernel.org/cgit/linux/kernel/git/mfleming/efi.git/log/?h=next
> 
> My comments were made with that branch in mind.
> 
Hi Matt,
Sorry for my misunderstanding, I will try to rebase to next branch.

Thanks.
Yisheng Xie.

> .
>