linux-kernel - Re: [PATCH] sbitmap: initialize weight to zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cab7d4ae-3079-7add-d72b-1bdecf57e13d@kernel.dk>
Date:   Mon, 19 Sep 2016 08:20:45 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Colin King <colin.king@...onical.com>, linux-block@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sbitmap: initialize weight to zero

On 09/19/2016 07:34 AM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
>
> Variable weight is not being initialized to zero before it is
> used to compute the weight sum. Ensure it is initialized to zero.
>
> Found with static analysis with cppcheck:
> [lib/sbitmap.c:177]: (error) Uninitialized variable: weight

Thanks, applied. Strange, this is an old issue, it was just moved to 
this file. It should have triggered on mainline too. My compiler doesn't 
complain here:

$ gcc --version
gcc (Ubuntu 6.2.0-3ubuntu11~16.04) 6.2.0 20160901

-- 
Jens Axboe