linux-kernel - Re: [PATCH] ovl: avoid setting uninitialized creds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJfpegtpmP+tZ4cQHEO7tOpA0aLBfc1x-mrrpO5m4+pzaAc+Jw@mail.gmail.com>
Date:   Mon, 19 Sep 2016 16:53:14 +0200
From:   Miklos Szeredi <miklos@...redi.hu>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Vivek Goyal <vgoyal@...hat.com>, Al Viro <viro@...iv.linux.org.uk>,
        Andreas Gruenbacher <agruenba@...hat.com>,
        "linux-unionfs@...r.kernel.org" <linux-unionfs@...r.kernel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ovl: avoid setting uninitialized creds

On Mon, Sep 19, 2016 at 2:38 PM, Arnd Bergmann <arnd@...db.de> wrote:
> If the call to ovl_copy_up() fails, we now call revert_creds on
> an uninitialized structure after a recent patch, as found
> by "gcc -Wmayby-uninitialized":
>
> fs/overlayfs/inode.c: In function 'ovl_open_maybe_copy_up':
> fs/overlayfs/inode.c:39:2: error: 'old_cred' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> fs/overlayfs/inode.c:22:21: note: 'old_cred' was declared here
>
> This changes the code back to not call revert_creds unless
> we have already called ovl_override_creds().

Thanks.   Slightly reworked fix folded into original patch and pushed out.

Thanks,
Miklos