linux-kernel - Re: [PATCH] megaraid_sas: clean function declarations in megaraid_sas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq11t0fanhm.fsf@sermon.lab.mkp.net>
Date:   Mon, 19 Sep 2016 12:00:21 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Baoyou Xie <baoyou.xie@...aro.org>
Cc:     kashyap.desai@...gotech.com, sumit.saxena@...gotech.com,
        uday.lingala@...gotech.com, jejb@...ux.vnet.ibm.com,
        martin.petersen@...cle.com, megaraidlinux.pdl@...gotech.com,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        arnd@...db.de, xie.baoyou@....com.cn
Subject: Re: [PATCH] megaraid_sas: clean function declarations in megaraid_sas_base.c up

>>>>> "Baoyou" == Baoyou Xie <baoyou.xie@...aro.org> writes:

Baoyou> We get a few warnings when building kernel with W=1:
Baoyou> drivers/scsi/megaraid/megaraid_sas_fusion.c:281:1: warning: no
Baoyou> previous prototype for 'megasas_free_cmds_fusion'
Baoyou> [-Wmissing-prototypes]
Baoyou> drivers/scsi/megaraid/megaraid_sas_fusion.c:714:1: warning: no
Baoyou> previous prototype for 'megasas_ioc_init_fusion'
Baoyou> [-Wmissing-prototypes] ....

Baoyou> In fact, these functions are declared in
Baoyou> drivers/scsi/megaraid/megaraid_sas_base.c, but should be
Baoyou> declared in a header file, thus can be recognized in other file.

Baoyou> So this patch adds the declarations into
Baoyou> drivers/scsi/megaraid/megaraid_sas_fusion.h.

Applied to 4.9/scsi-queue.

-- 
Martin K. Petersen	Oracle Linux Engineering