linux-kernel - Re: [PATCH] phy: meson-usb2: Fix build dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m2r38fhmav.fsf@baylibre.com>
Date:   Mon, 19 Sep 2016 09:44:08 -0700
From:   Kevin Hilman <khilman@...libre.com>
To:     Martin Blumenstingl <martin.blumenstingl@...glemail.com>
Cc:     Axel Lin <axel.lin@...ics.com>,
        Kishon Vijay Abraham I <kishon@...com>,
        Jerome Brunet <jbrunet@...libre.com>,
        linux-kernel@...r.kernel.org, linux-amlogic@...ts.infradead.org
Subject: Re: [PATCH] phy: meson-usb2: Fix build dependency

Martin Blumenstingl <martin.blumenstingl@...glemail.com> writes:

> Hi Axel,
>
> On Fri, Sep 16, 2016 at 4:07 AM, Axel Lin <axel.lin@...ics.com> wrote:
>> of_usb_get_dr_mode_by_phy will not be compiled if !USB_COMMON, fix below
>> build error:
>>
>> drivers/built-in.o: In function `phy_meson_usb2_probe':
>> debugfs.c:(.text+0x76b4): undefined reference to `of_usb_get_dr_mode_by_phy'
>> Makefile:961: recipe for target 'vmlinux' failed
>> make: *** [vmlinux] Error 1
>>
>> Signed-off-by: Axel Lin <axel.lin@...ics.com>
>> ---
>>  drivers/phy/Kconfig | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
>> index 6ad87ec..cc27c12 100644
>> --- a/drivers/phy/Kconfig
>> +++ b/drivers/phy/Kconfig
>> @@ -458,6 +458,8 @@ config PHY_MESON_USB2
>>         tristate "Meson USB2 PHY driver"
>>         default ARCH_MESON
>>         depends on OF && (ARCH_MESON || COMPILE_TEST)
>> +       depends on USB_SUPPORT
>> +       select USB_COMMON
>>         select GENERIC_PHY
>>         help
>>           Enable this to support the Meson USB2 PHYs found in Meson8b
>> --
>> 2.7.4
>>
> thanks for this patch!
>
> How do we handle patches for drivers which will (unfortunately) not
> land in the linux 4.8 - should I integrate that into v3 of the patch
> (which I'll have to send anyways) or do we keep them separate?
> Maybe Kishon and/or Kevin can share their opinion on this.

It's up to Kishon if he wants a v3, or if he can fold in the fix
himself.

Kevin