linux-kernel - Re: [PATCH] power: gpio_charger: switch to using GPIO descriptors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdYNiKJ1b9M0a1qe4R5bnYub_H+UZgN05G_m95DFk8-AXw@mail.gmail.com>
Date:   Mon, 19 Sep 2016 21:31:56 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Sebastian Reichel <sre@...nel.org>
Cc:     Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        David Woodhouse <dwmw2@...radead.org>,
        Heiko Stuebner <heiko@...ech.de>,
        Lars-Peter Clausen <lars@...afoo.de>
Subject: Re: [PATCH] power: gpio_charger: switch to using GPIO descriptors

On Mon, Sep 19, 2016 at 9:18 PM, Sebastian Reichel <sre@...nel.org> wrote:
> On Fri, Sep 09, 2016 at 01:40:04PM +0200, Linus Walleij wrote:
>> The GPIO charger is using a mix of the legacy GPIO interface
>> and <linux/of_gpio.h> which is not the modern way to use GPIOs.
>>
>> Refactor like this:
>>
>> - Use a GPIO descriptor for the GPIO line used to monitor the
>>   charger.
>> - Fetch the descriptor with devm_gpiod_get() as the first
>>   method.
>> - If this fails and we are *not* using device tree, then
>>   start looking to see if we can use platform data instead.
>> - After looking up and requesting a GPIO number with the
>>   legacy API, convert it to a descriptor.
>>
>> This way we can later isolate and drop the legacy code as
>> more platforms move over to using descriptors.
>>
>> Cc: Dmitry Eremin-Solenikov <dbaryshkov@...il.com>
>> Cc: Heiko Stuebner <heiko@...ech.de>
>> Cc: Lars-Peter Clausen <lars@...afoo.de>
>> Signed-off-by: Linus Walleij <linus.walleij@...aro.org>
>> ---
>> I would be very happy if some people can test this. I think
>> only the chromebook use it from device tree, but I'm equally
>> interested in the legacy usecase to work as nice as before.
>
> Since this is not tested on any hardware and we're already
> at rc7, I would prefer to take this after the merge window.
> Any reason this should go into v4.9?

No, there is no hurry.

>>  drivers/power/gpio-charger.c | 84 ++++++++++++++++++++++++++------------------
>>  1 file changed, 50 insertions(+), 34 deletions(-)
>
> This is obviously not based on power-supply's next branch, since
> I moved all drivers to drivers/power/supply.

I will rebase and resend after v4.9-rc1 then.

Yours,
Linus Walleij