linux-kernel - Re: [PATCH 1/2] power: bq27xxx_battery: add configurable poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160919194602.isutlr2thnyxck6m@earth>
Date:   Mon, 19 Sep 2016 21:46:03 +0200
From:   Sebastian Reichel <sre@...nel.org>
To:     Matt Ranostay <mranostay@...il.com>
Cc:     "Andrew F . Davis" <afd@...com>, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Matt Ranostay <matt@...ostay.consulting>
Subject: Re: [PATCH 1/2] power: bq27xxx_battery: add configurable
 poll_interval by sysfs

Hi,

On Fri, Sep 16, 2016 at 08:42:54PM -0700, Matt Ranostay wrote:
> Allow the poll_interval to be runtime configurable via an sysfs
> entry.  This is needed for udev control of the poll interval.
> 
> Signed-off-by: Matt Ranostay <matt@...ostay.consulting>
> ---
>  drivers/power/supply/bq27xxx_battery.c | 48 +++++++++++++++++++++++++++++++++-
>  1 file changed, 47 insertions(+), 1 deletion(-)

New sysfs attributes should be documented in Documentation/ABI.

Also I'm not too keen to add this, as there is already the sysfs
entry for the module parameter. I don't see any reason why udev
should not be able to change that value, so fix udev instead of
duplicating functionality in the kernel.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)