linux-kernel - Re: [PATCH 1/6] arcmsr: use pci_alloc_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq1shsv8vpl.fsf@sermon.lab.mkp.net>
Date:   Mon, 19 Sep 2016 16:45:42 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Christoph Hellwig <hch@....de>
Cc:     hans.verkuil@...co.com, brking@...ibm.com,
        haver@...ux.vnet.ibm.com, ching2048@...ca.com.tw, axboe@...com,
        alex.williamson@...hat.com, kvm@...r.kernel.org,
        linux-scsi@...r.kernel.org, linux-block@...r.kernel.org,
        linux-media@...r.kernel.org, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/6] arcmsr: use pci_alloc_irq_vectors

>>>>> "Christoph" == Christoph Hellwig <hch@....de> writes:

Christoph> Switch the arcmsr driver to use pci_alloc_irq_vectors.  We
Christoph> need to two calls to pci_alloc_irq_vectors as arcmsr only
Christoph> supports multiple MSI-X vectors, but not multiple MSI
Christoph> vectors.

Christoph> Otherwise this cleans up a lot of cruft and allows to use a
Christoph> common request_irq loop for irq types, which happens to only
Christoph> iterate over a single line in the non MSI-X case.

Ching: Please test and review. Thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering