linux-kernel - Re: [PATCH] mfd/gpio: move HTC GPIO driver to GPIO subsystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160919223306.GM1041@n2100.armlinux.org.uk>
Date:   Mon, 19 Sep 2016 23:33:07 +0100
From:   Russell King - ARM Linux <linux@...linux.org.uk>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     lee.jones@...aro.org, linux-kernel@...r.kernel.org, arm@...nel.org
Subject: Re: [PATCH] mfd/gpio: move HTC GPIO driver to GPIO subsystem

On Fri, Sep 16, 2016 at 01:52:50PM +0200, Linus Walleij wrote:
> Russell/ARM SoC: heads-up and ACK request.

Fine with one exception:

> diff --git a/arch/arm/mach-sa1100/h3xxx.c b/arch/arm/mach-sa1100/h3xxx.c
> index b1d4faa12f9a..75ab3b086e6f 100644
> --- a/arch/arm/mach-sa1100/h3xxx.c
> +++ b/arch/arm/mach-sa1100/h3xxx.c
> @@ -14,7 +14,7 @@
>  #include <linux/gpio.h>
>  #include <linux/gpio_keys.h>
>  #include <linux/input.h>
> -#include <linux/mfd/htc-egpio.h>
> +#include <linux/platform_data/gpio-htc-egpio.h>
>  #include <linux/mtd/mtd.h>
>  #include <linux/mtd/partitions.h>
>  #include <linux/platform_data/sa11x0-serial.h>

The includes here are arranged alphabetically with the exception of
linux/kernel.h, as per commit 4aa975558065 ("ARM: 5822/1: SA1100:
h3100/h3600: clean up #includes") - please keep them alphabetical.

Thanks.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.