linux-kernel - [PATCH 0/2] cris: fix a couple of incompatible pointer types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1474266477-26090-1-git-send-email-wagi@monom.org>
Date:   Mon, 19 Sep 2016 08:27:55 +0200
From:   Daniel Wagner <wagi@...om.org>
To:     linux-cris-kernel@...s.com
Cc:     Jesper Nilsson <jesper.nilsson@...s.com>,
        Mikael Starvik <starvik@...s.com>,
        Paul Gortmaker <paul.gortmaker@...driver.com>,
        linux-kernel@...r.kernel.org,
        Daniel Wagner <daniel.wagner@...-carit.de>
Subject: [PATCH 0/2] cris: fix a couple of incompatible pointer types

From: Daniel Wagner <daniel.wagner@...-carit.de>

Hi,

I got a love letter from kbuild about incompatible pointer types. I
added the new compiler flag [1] so it seems I am in charge cleaning up.

kbuild tells me:

All errors (new ones prefixed by >>):

   arch/cris/arch-v32/mm/intmem.c: In function 'crisv32_intmem_free':
   arch/cris/arch-v32/mm/intmem.c:116:14: warning: comparison of distinct pointer types lacks a cast
       if ((prev != &intmem_allocations) &&
                 ^~
   arch/cris/arch-v32/mm/intmem.c:123:14: warning: comparison of distinct pointer types lacks a cast
       if ((next != &intmem_allocations) &&
                 ^~
   In file included from include/linux/printk.h:5:0,
                    from include/linux/kernel.h:13,
                    from include/linux/list.h:8,
                    from arch/cris/arch-v32/mm/intmem.c:7:
   arch/cris/arch-v32/mm/intmem.c: At top level:
>> arch/cris/arch-v32/mm/intmem.c:148:17: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
    device_initcall(crisv32_intmem_init);
                    ^
   include/linux/init.h:184:58: note: in definition of macro '__define_initcall'
     __attribute__((__section__(".initcall" #id ".init"))) = fn; \
                                                             ^~
   arch/cris/arch-v32/mm/intmem.c:148:1: note: in expansion of macro 'device_initcall'
    device_initcall(crisv32_intmem_init);
    ^~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

cheers,
daniel

[1] ea8daa7b9784 ("kbuild: Add option to turn incompatible pointer check
into error")

Daniel Wagner (2):
  cris: don't compare incompatible pointer type
  cris: use correct device_init() function signature

 arch/cris/arch-v32/mm/intmem.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

-- 
2.7.4