linux-kernel - RE: [tpmdd-devel] [PATCH 2/2] tpm: fix bad constant expressions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 20 Sep 2016 09:57:48 +0000
From:   "Winkler, Tomas" <tomas.winkler@...el.com>
To:     Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
CC:     Peter Huewe <peterhuewe@....de>,
        "moderated list:TPM DEVICE DRIVER" 
        <tpmdd-devel@...ts.sourceforge.net>,
        open list <linux-kernel@...r.kernel.org>
Subject: RE: [tpmdd-devel] [PATCH 2/2] tpm: fix bad constant expressions


> On Tue, Sep 20, 2016 at 07:08:40AM +0000, Winkler, Tomas wrote:
> >
> > > -----Original Message-----
> > > From: Jarkko Sakkinen [mailto:jarkko.sakkinen@...ux.intel.com]
> > > Sent: Monday, September 19, 2016 23:22
> > > To: Peter Huewe <peterhuewe@....de>
> > > Cc: moderated list:TPM DEVICE DRIVER <tpmdd-
> > > devel@...ts.sourceforge.net>; open list
> > > <linux-kernel@...r.kernel.org>
> > > Subject: [tpmdd-devel] [PATCH 2/2] tpm: fix bad constant expressions
> > >
> > > Sparse reports "bad constant expression" for the use of cpu_to_be32
> > > inside enums tpm_capabilities and tpm_sub_capabilities. Even though
> > > it is probably expanded to a constant expression, it is probably cleaner
> not to use it there.
> >
> >
> > Swap macros were rewritten due to possible compiler bug
> > https://lkml.org/lkml/2016/5/2/597
> > And the warning is actually a bug in sparse, it fails to detect constant
> expression now.
> 
> I still think that these must be change in order to have some consistency in
> the subsystem. Now there are two differing conventions.

Nothing against the convention just the commit message is misleading in that sense. 
Tomas