linux-kernel - Re: [PATCH] ALSA: line6: fix ifnullfree.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5h4m5au9ib.wl-tiwai@suse.de>
Date:   Tue, 20 Sep 2016 12:54:20 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     kbuild test robot <fengguang.wu@...el.com>
Cc:     Andrej Krutak <dev@...ree.sk>, kbuild-all@...org,
        alsa-devel@...a-project.org, Jaroslav Kysela <perex@...ex.cz>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: line6: fix ifnullfree.cocci warnings

On Tue, 20 Sep 2016 02:10:13 +0200,
kbuild test robot wrote:
> 
> sound/usb/line6/driver.c:484:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
> 
>  NULL check before some freeing functions is not needed.
> 
>  Based on checkpatch warning
>  "kfree(NULL) is safe this check is probably not required"
>  and kfreeaddr.cocci by Julia Lawall.
> 
> Generated by: scripts/coccinelle/free/ifnullfree.cocci
> 
> CC: Andrej Krutak <dev@...ree.sk>
> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>

Applied, thanks.


Takashi


> ---
> 
>  driver.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> --- a/sound/usb/line6/driver.c
> +++ b/sound/usb/line6/driver.c
> @@ -480,8 +480,7 @@ static void line6_destruct(struct snd_ca
>  	/* Free buffer memory first. We cannot depend on the existence of private
>  	 * data from the (podhd) module, it may be gone already during this call
>  	 */
> -	if (line6->buffer_message)
> -		kfree(line6->buffer_message);
> +	kfree(line6->buffer_message);
>  
>  	kfree(line6->buffer_listen);
>  
>