linux-kernel - Re: [PATCH] gpio: Added zynq specific check for special pins on bank zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160920140633.GD16583@xsjsorenbubuntu>
Date:   Tue, 20 Sep 2016 07:06:33 -0700
From:   Sören Brinkmann <soren.brinkmann@...inx.com>
To:     Nava kishore Manne <nava.manne@...inx.com>
CC:     <linus.walleij@...aro.org>, <gnurou@...il.com>,
        <michal.simek@...inx.com>, <linux-gpio@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>,
        Nava kishore Manne <navam@...inx.com>
Subject: Re: [PATCH] gpio: Added zynq specific check for special pins on bank
 zero

On Tue, 2016-09-20 at 14:02:04 +0530, Nava kishore Manne wrote:
> From: Nava kishore Manne <nava.manne@...inx.com>
> 
> This patch adds zynq specific check for bank 0 pins 7 and 8
> are special and cannot be used as inputs
> 
> Signed-off-by: Nava kishore Manne <navam@...inx.com>
> ---
>  drivers/gpio/gpio-zynq.c | 17 +++++++++++++++--
>  1 file changed, 15 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-zynq.c b/drivers/gpio/gpio-zynq.c
> index e72794e..eae9d24 100644
> --- a/drivers/gpio/gpio-zynq.c
> +++ b/drivers/gpio/gpio-zynq.c
> @@ -96,6 +96,10 @@
>  /* GPIO upper 16 bit mask */
>  #define ZYNQ_GPIO_UPPER_MASK 0xFFFF0000
>  
> +/* For GPIO quirks */
> +#define ZYNQ_GPIO	BIT(0)
> +#define ZYNQMP_GPIO	BIT(1)

I'd make sure all quirks are easily identifiable and call them something
like 'ZYNQ_GPIO_QUIRK_FOO'

Apart from that:
Acked-by: Sören Brinkmann <soren.brinkmann@...inx.com>

	Sören