linux-kernel - Re: [PATCH] staging: lustre: ptlrpc: re-export lustre_swab_[lmv|lov]_mds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.20.1609201613110.3557@casper.infradead.org>
Date:   Tue, 20 Sep 2016 16:18:01 +0100 (BST)
From:   James Simmons <jsimmons@...radead.org>
To:     Dan Carpenter <dan.carpenter@...cle.com>
cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org, James Simmons <uja.ornl@...oo.com>,
        Andreas Dilger <andreas.dilger@...el.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Oleg Drokin <oleg.drokin@...el.com>,
        Lustre Development List <lustre-devel@...ts.lustre.org>
Subject: Re: [PATCH] staging: lustre: ptlrpc: re-export
 lustre_swab_[lmv|lov]_mds_md


> > On Mon, Sep 19, 2016 at 01:27:05PM -0400, James Simmons wrote:
> > > Being over zealous in removing unused EXPORT_SYMBOLs two functions
> > > lustre_swab_[lmv|lov]_mds_md exports were removed. They need to be
> > > exported so this patch restores those EXPORT_SYMBOLS. Same mistake
> > > was done when porting to the upstream client.
> > 
> > How did our build testing not catch this?  What needs these exports?  Is
> > it any in-kernel code?
> > 
> > confused,
> 
> It did catch it...  James, every patch has to be buildable (bisectable)
> so the original patch is never going to be merged.

We missed it original as well due to the fact it showed up on only 
specific platforms. I have no idea why that is. The majority of the
time it works. BTW is there a way to run kbuild bot on a patch set
before submission to avoid these corner cases.