linux-kernel - Re: [PATCH] cpufreq: fix up conversion to hotplug state machine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1534771.MnBsZb4zcz@vostro.rjw.lan>
Date:   Tue, 20 Sep 2016 18:17:36 +0200
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc:     peterz@...radead.org, mingo@...nel.org, hpa@...or.com,
        linux-kernel@...r.kernel.org, tglx@...utronix.de,
        Borislav Petkov <bp@...en8.de>
Subject: Re: [PATCH] cpufreq: fix up conversion to hotplug state machine

On Tuesday, September 20, 2016 04:56:28 PM Sebastian Andrzej Siewior wrote:
> The function cpufreq_register_driver() returns zero on success and since
> commit 27622b061eb4 ("cpufreq: Convert to hotplug state machine")
> erroneously a positive number. Due to the "if (x) assume_error" construct
> all callers assumed an error and things went south.
> This patch resets the return value back to zero in the success case.
> 
> Fixes: 27622b061eb4 ("cpufreq: Convert to hotplug state machine")
> Reported-by: Borislav Petkov <bp@...en8.de>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>

ACK

> ---
>  drivers/cpufreq/cpufreq.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index e0bc632a259e..8b44de4d7438 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -2503,6 +2503,7 @@ int cpufreq_register_driver(struct cpufreq_driver *driver_data)
>  	if (ret < 0)
>  		goto err_if_unreg;
>  	hp_online = ret;
> +	ret = 0;
>  
>  	pr_debug("driver %s up and running\n", driver_data->name);
>  	goto out;
>