linux-kernel - Re: [PATCH v5] mtd: spi-nor: Add support for S3AN spi-nor devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPybu_02pTOkfqKW2D4mNvK5fGWq9uTiOUw9rvs1Fa+gWNLh+g@mail.gmail.com>
Date:   Tue, 20 Sep 2016 20:01:26 +0200
From:   Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
To:     Boris Brezillon <boris.brezillon@...e-electrons.com>
Cc:     Cyrille Pitchen <cyrille.pitchen@...el.com>,
        David Woodhouse <dwmw2@...radead.org>,
        Brian Norris <computersforpeace@...il.com>,
        Javier Martinez Canillas <javier@....samsung.com>,
        Stephen Warren <swarren@...dia.com>,
        Jagan Teki <jteki@...nedev.com>, Vignesh R <vigneshr@...com>,
        Marek Vasut <marex@...x.de>,
        Ezequiel García <ezequiel@...guardiasur.com.ar>,
        Rafał Miłecki <zajec5@...il.com>,
        Furquan Shaikh <furquan@...gle.com>,
        "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5] mtd: spi-nor: Add support for S3AN spi-nor devices

Hi Boris

On Tue, Sep 20, 2016 at 6:25 PM, Boris Brezillon
<boris.brezillon@...e-electrons.com> wrote:

>>       while (len) {
>> -             ret = nor->read(nor, from, len, buf);
>> +             loff_t addr = from;
>> +
>> +             if (nor->flags & SNOR_F_S3AN_ADDR_DEFAULT)
>> +                     addr = spi_nor_s3an_addr_convert(nor, addr);

That should not be an issue, the bigest s3an is  less than 4 MBytes :)

Thanks for your review



-- 
Ricardo Ribalda