linux-kernel - Re: [PATCH 47/61] perf c2c report: Add cacheline browser

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160920151007.ad88298262bc99a968c95cd5@arm.com>
Date:   Tue, 20 Sep 2016 15:10:07 -0500
From:   Kim Phillips <kim.phillips@....com>
To:     Jiri Olsa <jolsa@...nel.org>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        lkml <linux-kernel@...r.kernel.org>,
        Don Zickus <dzickus@...hat.com>, Joe Mario <jmario@...hat.com>,
        Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Namhyung Kim <namhyung@...nel.org>,
        David Ahern <dsahern@...il.com>,
        Andi Kleen <andi@...stfloor.org>
Subject: Re: [PATCH 47/61] perf c2c report: Add cacheline browser

On Mon, 19 Sep 2016 15:09:56 +0200
Jiri Olsa <jolsa@...nel.org> wrote:

> +	/* reset abort key so that it can get Ctrl-C as a key */
> +	SLang_reset_tty();
> +	SLang_init_tty(0, 0, 0);

this fails to build on systems without slang:

  CC       builtin-c2c.o
builtin-c2c.c: In function ‘perf_c2c__browse_cacheline’:
builtin-c2c.c:2211:2: error: implicit declaration of function ‘SLang_reset_tty’ [-Werror=implicit-function-declaration]
  SLang_reset_tty();
  ^
builtin-c2c.c:2211:2: error: nested extern declaration of ‘SLang_reset_tty’ [-Werror=nested-externs]
builtin-c2c.c:2212:2: error: implicit declaration of function ‘SLang_init_tty’ [-Werror=implicit-function-declaration]
  SLang_init_tty(0, 0, 0);
  ^
builtin-c2c.c:2212:2: error: nested extern declaration of ‘SLang_init_tty’ [-Werror=nested-externs]
cc1: all warnings being treated as errors
mv: cannot stat ‘./.builtin-c2c.o.tmp’: No such file or directory
tools/build/Makefile.build:77: recipe for target 'builtin-c2c.o' failed

Thanks,

Kim