linux-kernel - Re: [PATCH net-next] net: dsa: mv88e6xxx: handle multiple ports in ATU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160920001914.GB6323@lunn.ch>
Date:   Tue, 20 Sep 2016 02:19:14 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Vivien Didelot <vivien.didelot@...oirfairelinux.com>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel@...oirfairelinux.com,
        "David S. Miller" <davem@...emloft.net>,
        Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: handle multiple ports in
 ATU

Hi Vivien

> +	do {
> +		err = _mv88e6xxx_atu_getnext(chip, fid, &next);
> +		if (err)
> +			return err;
> +
> +		if (next.state == GLOBAL_ATU_DATA_STATE_UNUSED)
> +			break;
> +
> +		if (ether_addr_equal(next.mac, addr)) {
> +			*entry = next;
> +			return 0;
> +		}
> +	} while (!is_broadcast_ether_addr(next.mac));

This is correct, but i wonder how well it scales? When we have a lot
of entries in the ATU, this is going to take time. At some point in
the future, we might want to keep a shadow copy of static entries of
the ATU in RAM. We then don't need to search for them.

But that is for later, once we have some complaints this is too slow.

    Andrew