linux-kernel - Re: [PATCH 1/2] rtc: Add some dummy static inline functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 20 Sep 2016 23:36:10 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Baolin Wang <baolin.wang@...aro.org>
cc:     a.zummo@...ertech.it, alexandre.belloni@...e-electrons.com,
        rostedt@...dmis.org, mingo@...hat.com, john.stultz@...aro.org,
        broonie@...nel.org, linux-kernel@...r.kernel.org,
        rtc-linux@...glegroups.com
Subject: Re: [PATCH 1/2] rtc: Add some dummy static inline functions

On Sun, 18 Sep 2016, Baolin Wang wrote:

> The patch 2 in this patchset adding tracepoints for alarmtimers will build
> failed on S390 platform, due to S390 defconfig did not define CONFIG_RTC_LIB
> macro to define the rtc_ktime_to_tm() function which is used in this patch.
> Thus we should add some ummy static inline functions in case CONFIG_RTC_LIB
> is not defined.

I told you before that adding these inlines has the danger that we
introduce code which uses these functions in places which does not depend
on RTC_LIB. The resulting wreckage is going to be subtle and hard to debug.

This still stands and this patch is going nowhere.

Thanks,

	tglx