linux-kernel - Re: [PATCH RESEND] drm/ast: free correct pointer in astfb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <c721b459-11b6-cbac-f97a-a0a2fcc5712a@au1.ibm.com>
Date:   Tue, 20 Sep 2016 12:54:55 +1000
From:   Andrew Donnellan <andrew.donnellan@....ibm.com>
To:     airlied@...ux.ie, dri-devel@...ts.freedesktop.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND] drm/ast: free correct pointer in astfb_create()
 error paths

On 20/09/16 11:56, Andrew Donnellan wrote:
> In the err_free_vram and err_release_fbi error paths in astfb_create(), we
> attempt to free afbdev->sysram. The only jumps to these error paths occur
> before we assign afbdev->sysram = sysram. Free sysram instead.
>
> Signed-off-by: Andrew Donnellan <andrew.donnellan@....ibm.com>
>
> ---
>
> Found by Coverity Scan. Compile tested only.
>
> Resending as it looks like this didn't hit dri-devel.

It did show up after all :)

-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan@....ibm.com  IBM Australia Limited