linux-kernel - [tip:x86/asm] x86/dumpstack: Fix show

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-71f5443ebb1227c22e8decbcd28a1ea6deaf8257@git.kernel.org>
Date:   Tue, 20 Sep 2016 14:48:44 -0700
From:   tip-bot for Josh Poimboeuf <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     mingo@...nel.org, torvalds@...ux-foundation.org, bp@...en8.de,
        luto@...nel.org, tglx@...utronix.de, brgerst@...il.com,
        tipbot@...or.com, jpoimboe@...hat.com, dvlasenk@...hat.com,
        linux-kernel@...r.kernel.org, hpa@...or.com, peterz@...radead.org
Subject: [tip:x86/asm] x86/dumpstack: Fix show_stack() task pointer
 regression

Commit-ID:  71f5443ebb1227c22e8decbcd28a1ea6deaf8257
Gitweb:     http://git.kernel.org/tip/71f5443ebb1227c22e8decbcd28a1ea6deaf8257
Author:     Josh Poimboeuf <jpoimboe@...hat.com>
AuthorDate: Tue, 20 Sep 2016 10:53:40 -0500
Committer:  Ingo Molnar <mingo@...nel.org>
CommitDate: Tue, 20 Sep 2016 23:36:37 +0200

x86/dumpstack: Fix show_stack() task pointer regression

With the following commit:

  e18bcccd1a4e ("x86/dumpstack: Convert show_trace_log_lvl() to use the new unwinder")

The task pointer argument to show_stack_log_lvl() in show_stack() was
inadvertently changed to 'current'.

Signed-off-by: Josh Poimboeuf <jpoimboe@...hat.com>
Cc: Andy Lutomirski <luto@...nel.org>
Cc: Borislav Petkov <bp@...en8.de>
Cc: Brian Gerst <brgerst@...il.com>
Cc: Denys Vlasenko <dvlasenk@...hat.com>
Cc: H. Peter Anvin <hpa@...or.com>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Thomas Gleixner <tglx@...utronix.de>
Cc: byungchul.park@....com
Cc: fweisbec@...il.com
Cc: keescook@...omium.org
Cc: linux-tip-commits@...r.kernel.org
Cc: luto@...capital.net
Cc: nilayvaish@...il.com
Cc: rostedt@...dmis.org
Cc: tip-bot for Josh Poimboeuf <tipbot@...or.com>
Fixes: e18bcccd1a4e ("x86/dumpstack: Convert show_trace_log_lvl() to use the new unwinder")
Link: http://lkml.kernel.org/r/20160920155340.yhewlx7vmgmov5fb@treble
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
 arch/x86/kernel/dumpstack.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel/dumpstack.c
index 999de3b..9b7cf5c 100644
--- a/arch/x86/kernel/dumpstack.c
+++ b/arch/x86/kernel/dumpstack.c
@@ -164,7 +164,7 @@ void show_stack(struct task_struct *task, unsigned long *sp)
 	if (!sp && task == current)
 		sp = get_stack_pointer(current, NULL);
 
-	show_stack_log_lvl(current, NULL, sp, "");
+	show_stack_log_lvl(task, NULL, sp, "");
 }
 
 void show_stack_regs(struct pt_regs *regs)