linux-kernel - Re: [PATCH] drm/amdgpu: remove unused functions

Open Source and information security mailing list archives

Message-ID: <CADnq5_MLKC+KZ236cWKk-UOo3rdS6AvKWj2KNJhJrkshpNt7Cg@mail.gmail.com>
Date:   Tue, 20 Sep 2016 00:27:56 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     Christian König <christian.koenig@....com>
Cc:     Baoyou Xie <baoyou.xie@...aro.org>,
        "oded.gabbay@...il.com" <oded.gabbay@...il.com>,
        "Deucher, Alexander" <Alexander.Deucher@....com>,
        "airlied@...ux.ie" <airlied@...ux.ie>,
        "Li, Samuel" <Samuel.Li@....com>,
        "Zhou, Jammy" <Jammy.Zhou@....com>,
        "xie.baoyou@....comm.cn" <xie.baoyou@....comm.cn>,
        "arnd@...db.de" <arnd@...db.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH] drm/amdgpu: remove unused functions

On Mon, Sep 19, 2016 at 6:02 AM, Christian König
<christian.koenig@....com> wrote:
> Am 18.09.2016 um 16:13 schrieb Baoyou Xie:
>>
>> We get 2 warnings when building kernel with W=1:
>> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c:146:5: warning: no previous
>> prototype for 'pool_to_domain' [-Wmissing-prototypes]
>> drivers/gpu/drm/amd/amdgpu/cz_smc.c:104:5: warning: no previous prototype
>> for 'cz_send_msg_to_smc_with_parameter_async' [-Wmissing-prototypes]
>>
>> In fact, both functions are called by no one and not exported,
>> so this patch removes them.
>>
>> Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>
>
>
> Reviewed-by: Christian König <christian.koenig@....com>
>
>

Applied.  thanks!

Alex

>> ---
>>   drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 8 --------
>>   drivers/gpu/drm/amd/amdgpu/cz_smc.c        | 7 -------
>>   2 files changed, 15 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
>> index d080d08..dba8a5b 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
>> @@ -143,14 +143,6 @@ int amdgpu_amdkfd_resume(struct amdgpu_device *rdev)
>>         return r;
>>   }
>>   -u32 pool_to_domain(enum kgd_memory_pool p)
>> -{
>> -       switch (p) {
>> -       case KGD_POOL_FRAMEBUFFER: return AMDGPU_GEM_DOMAIN_VRAM;
>> -       default: return AMDGPU_GEM_DOMAIN_GTT;
>> -       }
>> -}
>> -
>>   int alloc_gtt_mem(struct kgd_dev *kgd, size_t size,
>>                         void **mem_obj, uint64_t *gpu_addr,
>>                         void **cpu_ptr)
>> diff --git a/drivers/gpu/drm/amd/amdgpu/cz_smc.c
>> b/drivers/gpu/drm/amd/amdgpu/cz_smc.c
>> index 69ac373c4..db67e0c 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/cz_smc.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/cz_smc.c
>> @@ -101,13 +101,6 @@ int cz_send_msg_to_smc(struct amdgpu_device *adev,
>> u16 msg)
>>         return 0;
>>   }
>>   -int cz_send_msg_to_smc_with_parameter_async(struct amdgpu_device *adev,
>> -                                               u16 msg, u32 parameter)
>> -{
>> -       WREG32(mmSMU_MP1_SRBM2P_ARG_0, parameter);
>> -       return cz_send_msg_to_smc_async(adev, msg);
>> -}
>> -
>>   int cz_send_msg_to_smc_with_parameter(struct amdgpu_device *adev,
>>                                                 u16 msg, u32 parameter)
>>   {
>
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives