linux-kernel - Re: [PATCH 1/1] mm/hugetlb: fix memory offline with hugepage size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <05d701d213d1$7fb70880$7f251980$@alibaba-inc.com>
Date:   Wed, 21 Sep 2016 14:29:25 +0800
From:   "Hillf Danton" <hillf.zj@...baba-inc.com>
To:     "'Gerald Schaefer'" <gerald.schaefer@...ibm.com>,
        "'Andrew Morton'" <akpm@...ux-foundation.org>,
        "'Naoya Horiguchi'" <n-horiguchi@...jp.nec.com>
Cc:     <linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>,
        "'Michal Hocko'" <mhocko@...e.cz>,
        "'Kirill A . Shutemov'" <kirill.shutemov@...ux.intel.com>,
        "'Vlastimil Babka'" <vbabka@...e.cz>,
        "'Mike Kravetz'" <mike.kravetz@...cle.com>,
        "'Aneesh Kumar K . V'" <aneesh.kumar@...ux.vnet.ibm.com>,
        "'Martin Schwidefsky'" <schwidefsky@...ibm.com>,
        "'Heiko Carstens'" <heiko.carstens@...ibm.com>
Subject: Re: [PATCH 1/1] mm/hugetlb: fix memory offline with hugepage size > memory block size

> @@ -1466,9 +1468,9 @@ void dissolve_free_huge_pages(unsigned long start_pfn, unsigned long end_pfn)
>  	if (!hugepages_supported())
>  		return;
> 
> -	VM_BUG_ON(!IS_ALIGNED(start_pfn, 1 << minimum_order));

Then the relevant comment has to be updated.

Hillf
>  	for (pfn = start_pfn; pfn < end_pfn; pfn += 1 << minimum_order)
> -		dissolve_free_huge_page(pfn_to_page(pfn));
> +		if (PageHuge(pfn_to_page(pfn)))
> +			dissolve_free_huge_page(pfn_to_page(pfn));
>  }
> 
>  /*
> --
> 2.8.4